[Snyk] Security upgrade del from 6.1.1 to 8.0.0 #8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
|
@RileySeaburg the What I Tested
|
|
Let's wait until #8188 is merged to merge this. |
|
@RileySeaburg |
nick-mon1
previously approved these changes
Nov 20, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RileySeaburg
requested changes
Nov 21, 2024
There was a problem hiding this comment.
@nick-mon1 Please remove npm-run-all It is no longer maintained.
Replace it with Concurrently
nick-mon1
reviewed
Nov 25, 2024
| @@ -21,7 +21,7 @@ | |||
| "prettier:js:fix": "npx prettier -w 'themes/digital.gov/src/js/*.js' 'config/typescript/**/*.ts'", | |||
| "prettier:templates": "npx prettier -c ./themes/**/*.html", | |||
| "prettier:templates:fix": "npx prettier -w ./themes/**/*.html", | |||
| "start": "npm-run-all --parallel local-build hugo workflow", | |||
| "start": "concurrently \"npm run local-build\" \"npm run hugo\" \"npm run workflow\"", | |||
There was a problem hiding this comment.
@RileySeaburg Replaced with concurrently.
nick-mon1
reviewed
Nov 25, 2024
| @@ -44,7 +44,7 @@ | |||
| "@prantlf/jsonlint": "^14.0.3", | |||
| "@uswds/uswds": "^3.9.0", | |||
| "autoprefixer": "^10.4.16", | |||
| "del": "^6.1.1", | |||
| "concurrently": "^9.1.0", | |||
| "dotenv": "^16.3.1", | |||
| "eslint": "^8.56.0", | |||
There was a problem hiding this comment.
@RileySeaburg We should update to v9 during the next POAM. Made a note of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Has a fix available, CVSS 6.2
SNYK-JS-INFLIGHT-6095116
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: del
The new version differs by 10 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.