12/4/2024 Production Deploy Hotfix 2 #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the Redis plan in place is not supported - we would need to create a new cluster and then remove the old one. Signed-off-by: Carlo Costino <[email protected]>
Revert Redis plan back
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
terrazoon
previously approved these changes
Dec 4, 2024
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
terrazoon
approved these changes
Dec 4, 2024
stvnrlly
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
A hotfix of a hotfix, because we can't change Redis plans on the fly. We need to create a new cluster, bind the app to it, and then remove the old one.
This also includes an adjustment to add a TTL (expiration) to keys going to Redis for the
retry-tasksanddatabase-taskskeys.Security Considerations