Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed enzyme optimization with Kcat fitness function #237

Closed
wants to merge 3 commits into from
Closed

fix: fixed enzyme optimization with Kcat fitness function #237

wants to merge 3 commits into from

Conversation

yvesnana
Copy link
Contributor

Resolved inconsistencies in core.py and updated the example file to ensure accurate execution of optimization with the KCAT fitness model.

@cla-bot cla-bot
Copy link

cla-bot bot commented Apr 24, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cloud User.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@yvesnana yvesnana assigned yvesnana and unassigned yvesnana Apr 24, 2024
@yvesnana yvesnana requested a review from drugilsberg April 24, 2024 09:48
drugilsberg
drugilsberg requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@drugilsberg drugilsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the build and address comments and then it's good to go.

examples/enzeptional/example_enzeptional.py Outdated
@@ -5,12 +5,16 @@
from gt4sd.configuration import GT4SDConfiguration, sync_algorithm_with_s3


def initialize_environment():
def initialize_environment(model = "feasibility"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing and docstring missing, please add

src/gt4sd/frameworks/enzeptional/core.py Outdated
top_k: int = 2,
selection_ratio: float = 0.5,
perform_crossover: bool = False,
crossover_type: str = "uniform",
minimum_interval_length: int = 8,
pad_intervals: bool = False,
concat_order=["sequence", "substrate", "product"],
scaler_filepath: Optional[str] = None,
fitness_kcat: Optional[bool] = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the parameter to something more generic

@cla-bot cla-bot
Copy link

cla-bot bot commented Apr 24, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cloud User.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot
Copy link

cla-bot bot commented Apr 24, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cloud User.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@yvesnana yvesnana closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drugilsberg drugilsberg drugilsberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvesnana @drugilsberg