Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fullstack] Bugfixes and Chapter Managment #137

Closed
4 tasks done
johannesq23 opened this issue Oct 22, 2024 · 0 comments · Fixed by #141
Closed
4 tasks done

[Fullstack] Bugfixes and Chapter Managment #137

johannesq23 opened this issue Oct 22, 2024 · 0 comments · Fixed by #141
Assignees

Comments

@johannesq23
Copy link
Contributor

johannesq23 commented Oct 22, 2024

Context

We want to finish some things up regarding the chapter management and just fix some bugs that have been lingering around.

Requirements

Add Volunteer Modal

Allow the chapter president or higher to add a volunteer to the chapter, create this design similar to the chapter transfer. The list of volunteers should follow these parameters:
params: { roles: [Role.NONPROFIT_VOLUNTEER], approved: [AdminApprovalStatus.APPROVED], chapters: [""] },

Essentially, we want all the volunteers without a chapter

Pagination Fix

Currently, the pagination is always on the exact left. However, make it so that the highlighted tab is the second one from the left, which allows the user to see one previous and two incoming. This rule should apply to all the tabs except for the first page, and the last two pages.
Screenshot 2024-10-22 at 7 33 29 PM

Screenshot 2024-10-22 at 7 34 52 PM

No pending approvals

If there are no pending approvals, do not show the red button, this can be done with a pretty simple conditional or ternary statement

Popups upon deletion, approvals, and removals

Display a quick popup that just says Volunteer Successfully _____. This should happen in volunteer approval list, volunteer list, and volunteer list within a chapter. You can create a component for this that passes in a string argument or however you want.

Acceptance Criteria

  • Add Volunteer to Chapter Component added
  • Pagination Fixed
  • Pending Approvals Fixed
  • Popups exist
@ND68 ND68 self-assigned this Oct 24, 2024
@ND68 ND68 linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants