Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

j2cli not supported on python 3.12 #77

Closed
queria opened this issue Jun 14, 2024 · 2 comments · Fixed by #79 · May be fixed by #78
Closed

j2cli not supported on python 3.12 #77

queria opened this issue Jun 14, 2024 · 2 comments · Fixed by #79 · May be fixed by #78

Comments

@queria
Copy link
Contributor

queria commented Jun 14, 2024 •
edited
Loading

On system with newer python 3.12 current dependency on j2cli will not work.

Seems j2cli is currently not maintained as mentioned in kolypto/j2cli#80

Suggested there as possible alternative could be https://pypi.org/project/jinjanator/ (by its author).

Alternatively, if just env + template.j2 is needed, i think that directly using custom python script would be enough.
queria added a commit to queria/docker-gameserver that referenced this issue Jun 14, 2024
@queria
Custom py script for jinja2 rendering
b167cda 
As alternative to currently j2cli or such feature-full/heavy tool,
small custom python script is enough for rendering jinja2 templates.

Closes GameServerManagers#77
@queria queria mentioned this issue Jun 14, 2024
Open
queria added a commit to queria/docker-gameserver that referenced this issue Jun 14, 2024
@queria
Custom py script for jinja2 rendering
0983361 
As alternative to currently j2cli or such feature-full/heavy tool,
small custom python script is enough for rendering jinja2 templates.

Closes GameServerManagers#77
queria added a commit to queria/docker-gameserver that referenced this issue Jun 14, 2024
@queria
Use jinjanator instead of j2cli
b3cf288 
Switch to jinjanator as alternative to j2cli
for compatibility with python 3.12+.

Closes GameServerManagers#77
@queria queria mentioned this issue Jun 14, 2024
Merged
@queria
Copy link
Contributor Author

queria commented Jun 14, 2024

I've opened two PRs, for both - custom script as also for switching to jinjanator - feel free to pick preferred one, or none if other approach is desired.

@dgibbs64
Copy link
Member

Thanks. I will take a look at this

dgibbs64 pushed a commit that referenced this issue Jun 15, 2024
@queria
feat: use jinjanator instead of j2cli (#79)
897a36c 
Switch to jinjanator as alternative to j2cli
for compatibility with python 3.12+.

Closes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@queria @dgibbs64