Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package name from AndroidManfiest.xml to support AGP 8 #225

Merged
merged 2 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ def safeExtGet(prop, fallback) {
apply plugin: 'com.android.library'

android {
namespace 'com.gantix.JailMonkey'
compileSdkVersion safeExtGet('compileSdkVersion', 31)
buildToolsVersion safeExtGet('buildToolsVersion', "31.0.0")

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
if (agpVersion >= 7) {
namespace 'com.gantix.JailMonkey'
}

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 31)
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.gantix.JailMonkey">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ public static boolean hookDetected(Context context) {
PackageManager packageManager = context.getPackageManager();
List<ApplicationInfo> applicationInfoList = packageManager.getInstalledApplications(PackageManager.GET_META_DATA);
String[] dangerousPackages = {
"de.robv.android.xposed.installer",
"com.saurik.substrate",
"de.robv.android.xposed"
"de.robv.android.xposed.installer",
"com.saurik.substrate",
"de.robv.android.xposed",
"com.noshufou.android.su.elite",
"eu.chainfire.supersu",
"com.koushikdutta.superuser",
Expand All @@ -45,7 +45,7 @@ public static boolean hookDetected(Context context) {
"eu.chainfire.supersu.pro",
"com.kingouser.com",
"com.topjohnwu.magisk"
};
};

if (applicationInfoList != null) {
for (ApplicationInfo applicationInfo : applicationInfoList) {
Expand Down
Loading