Prepare v2.3.3 release (gwastro#4596)

* Use gating windows in sngl_minifollowup and allow 'triggers within vetoes' option (gwastro#4549)

* Use gating windows in sngl_minifollowup - also allow 'triggers within vetoes' option

* Minor fixes

* add infor if fewer triggers than requested

* Allow pycbc_sngls_minifollowup to use single ranking statistic

* Fix bug in rank_stat_single for quadsum/phasetd statistics

* mask may be boolean now

* fix broken pycbc_page_snglinfo due to bugfix

* page_snglinfo to use the ranking statistic used

* missed change

* Fix cases where ifar limit was not being applied (gwastro#4574)

* Fix cases where ifar limit was not being applied

* some more missed cases / long lines

* redoing a couple more long lines

* missed one more place

* unrelated bug where the IFOs were not in the right order for use with the significance_dict

* remove removal of downranked triggers (gwastro#4579)

* remove removal of downranked triggers

* add brief explanation into the caption

* bug in choosing the far calculation method (gwastro#4593)

* bug in which IFO combo is used for calculating the FAR in each combination during HR

* Safety catch

* Update release number

* add coordinates_space.py (gwastro#4289)

* add coordinates_space.py

* add LISA/SSB frame params

* add LISA_to_GEO and GEO_to_LISA

* add coordinates_space into FieldArray

* add doc and Astropy support

* update comments on sympy

* use fsolve from scipy instead

* fix cc issues

* fix cc issues

* minor fix

* update

* not use iteration

* decouple LISA orbit and more accurate Earth

* rename

* remove jplephem

* add the angular displacement of the Earth

* use radians

* make func readable in .ini

* reverse back to master

* correct psi range

* reverse to master

* fix unit issue in earth_position_SSB

* put LISA to the "right" position

* add LISA specific transform classes here

* change names

* update

* make a package for coordinates

* remove coordinates_space import

* move __all__ into __init__.py

* remove all coordinates_space

* change TIME_OFFSET to seconds

* fix SOBHB issue

* rename

* add SSB or LISA params into fid_params

* rename

* fix cc issues

* fix cc issue

* fix cc issue

* update

* update

* fix

* add default names

* overwrite params with same names

* remove pre-fixed names

* remove all pre-fixed names

* not pop

* fix inverse transform

* update tc

* not overwrite

* add SNR support for multi-model

* Update waveform.py

* t0 issue

* t0 issue

* Update space.py

* add obstime

* np.mod(psi_newframe, 2*np.pi)

* fix obstime

* add support for array inputs

* Update hierarchical.py

* just use Alex's implementation

* CustomTransformMultiOutputs is in another PR, so remove it

* add LDC and LAL convention correction

* use pycbc standard names

* more meaningful name

* use pycbc standard names

* Update relbin.py

* Update parameters.py

* remove unnecessary changes

* fix cc issue

* fix cc issue

* fix cc issue

* fix cc issue

* compactify

* compactify

* add __all__ back

* Update transforms.py

* Update transforms.py

* Update test_transforms.py

* Update transforms.py

* update doc

* fix time warning

* Update space.py

* Update test_transforms.py

* Create test_coordinates_space.py

* fix cc issues

* fix cc issues

* fix cc issue

* Update tox.ini

* Update tox.ini

* Update tox.ini

* Update tox.ini

* Update tox.ini

* Update tox.ini

* Update tox.ini

* Update test_coordinates_space.py

* add inline doc

* Update tox.ini

* add check of bbhx

* Update test_coordinates_space.py

* Update tox.ini

* Update test_coordinates_space.py

* add MultibandRelativeTimeDom into hierarchical.py

* Update __init__.py

* Update hierarchical.py

* Update hierarchical.py

* Update relbin.py

* Update hierarchical.py

* Update hierarchical.py

* Update relbin.py

* Update hierarchical.py

* Update hierarchical.py

* Update hierarchical.py

* Update hierarchical.py

* Update hierarchical.py

* Update relbin.py

* Update hierarchical.py

* Update hierarchical.py

* Update relbin.py

* Update __init__.py

* Update space.py

* Update space.py

* Update space.py

* fix psi issue

* Update test_coordinates_space.py

* Update test_coordinates_space.py

* update lalsimulation cvmfs path (gwastro#4580)

* update lalsimulation cvmfs path

* missed that the mount location needs to be changed as well

* more references to previsou CVMFS location

* Revert "add coordinates_space.py (gwastro#4289)"

This reverts commit e3418c7.

* REmoving lisa examples

* REmove inference examples

* Remove LISA deps

* Removing more LISA things

---------

Co-authored-by: Gareth S Cabourn Davies <[email protected]>
Co-authored-by: Shichao Wu <[email protected]>

bin/all_sky_search/pycbc_coinc_statmap_inj

@@ -33,7 +33,6 @@ init_logging(args.verbose)
 
 significance.check_significance_options(args, parser)
 
-
 window = args.cluster_window
 logging.info("Loading coinc zerolag triggers")
 zdata = pycbc.io.MultiifoStatmapData(files=args.zero_lag_coincs, ifos=args.ifos)

docs/inference.rst

@@ -505,8 +505,6 @@ Examples
     inference/examples/single.rst
     inference/examples/relative.rst
     inference/examples/hierarchical.rst
-    inference/examples/lisa_smbhb_ldc_pe.rst
-    inference/examples/lisa_smbhb_inj_pe.rst
     inference/examples/sampler_platter.rst
     inference/models.rst
 

docs/inference/models.rst

@@ -133,8 +133,6 @@ Heterodyne / Relative Models
     to the models that need to generate a full waveform for every likelihood
     as these will usually be much faster.
 
-    There is also support in this model for use with :ref:`LISA Sangria data analysis <inference_example_lisa_smbhb_ldc>` and :ref:`LISA injection data analysis <inference_example_lisa_smbhb_inj>`.
-
     Supported Marginalizations: distance, coa_phase (dominant mode), polarization
     +++
     Earth Rotation:✅ LISA:✅ Higher Modes:❌
@@ -166,16 +164,6 @@ Heterodyne / Relative Models
     +++
     Earth Rotation:❌ LISA:❌ Higher Modes:❌
 
-.. card:: Brute force LISA sky modes
-
-    ``'brute_lisa_sky_modes_marginalize'`` :py:class:`pycbc.inference.models.relbin.Relative`
-
-    The models does a brute force marginalization over the LISA sky mode
-    degeneracies. It is built upon the `relative` model
-
-    Supported Marginalizations: distance, coa_phase (dominant mode)
-    +++
-    Earth Rotation:❌ LISA:✅ Higher Modes:❌
 
 =========================================
 Extrinsic Parameter Only Models