fix(processes/scoring): get phantom param from step #80
+12
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves Bugzilla/Geant4 – Problem 2636. The changes to G4EnergySplitter here are focused on ensuring that each call to SplitEnergyInVolumes() utilizes the correct phantom parameterization. This involves the removal of the GetPhantomParam private method in favor of fetching the parameterization from the G4Step on each invocation of SplitEnergyInVolumes(). New exceptions are thrown if the G4Step does not refer to an appropriate phantom, or if the instance variable `thePhantomParam` is required but has not yet been initialized in SplitEnergyInVolumes().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves Bugzilla/Geant4 – Problem 2636.
The changes to G4EnergySplitter here are focused on ensuring that each call to SplitEnergyInVolumes() utilizes the correct phantom parameterization. This involves the removal of the GetPhantomParam private method in favor of fetching the parameterization from the G4Step on each invocation of SplitEnergyInVolumes(). New exceptions are thrown if the G4Step does not refer to an appropriate phantom, or if the instance variable
thePhantomParamis required but has not yet been initialized in SplitEnergyInVolumes().Note
No tests have been added to accompany this change since the ContinuousTest build target and all other build targets seem to have no tests to build on 🤷♂️.