Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography Component #5

Open
d-asensio opened this issue Oct 13, 2020 · 4 comments
Open

Typography Component #5

d-asensio opened this issue Oct 13, 2020 · 4 comments
Assignees

Comments

@d-asensio
Copy link
Collaborator

No description provided.

@victormartingarcia victormartingarcia self-assigned this Oct 13, 2020
@victormartingarcia
Copy link
Contributor

Create a generic component for text elements. See Typography component on Material Design for reference

@victormartingarcia victormartingarcia removed their assignment Oct 18, 2020
@victormartingarcia
Copy link
Contributor

I'm passing on that one 👎

This component is quite complex for a vue newbie like me... Checked vue material and seems they don't manage Typography as a component itself, but as a base scss

@d-asensio
Copy link
Collaborator Author

d-asensio commented Oct 18, 2020

No worries @victormartingarcia!

For what we've got in the design maybe you can simplify this and create a simple <Paragraph /> component which applies the right styles of the paragraphs (font-family, weight, etc.. but just for the <p> element).

This will be a good starting point for further development of the Typography component and will also help you to warm up and get familiar with Vue 👍

What do you think?

@victormartingarcia
Copy link
Contributor

sounds good! I'll do my best ;)

@victormartingarcia victormartingarcia self-assigned this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants