Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli refactor #682

Merged
merged 5 commits into from
Apr 28, 2024
Merged

feat: cli refactor #682

merged 5 commits into from
Apr 28, 2024

Conversation

DOOduneye
Copy link
Contributor

@DOOduneye DOOduneye commented Apr 28, 2024 •
edited
Loading

  • Still need to update the CONTRIBUTING.md and create documentation for the cli

@garrettladley garrettladley requested review from a team and garrettladley and removed request for a team April 28, 2024 19:29
@DOOduneye DOOduneye linked an issue Apr 28, 2024 that may be closed by this pull request
feat: ci #680
Closed
@garrettladley garrettladley changed the title Cli refactor feat: cli refactor Apr 28, 2024
garrettladley
garrettladley requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits my 👑 also, should these frontend changes be in a diff PR? or are they as a result of formatting/linting with the updated CLI?

cli/.golangci.yml Outdated Show resolved Hide resolved
cli/LICENSE Outdated Show resolved Hide resolved
cli/cmd/format.go Outdated Show resolved Hide resolved
cli/cmd/lint.go Outdated Show resolved Hide resolved
@garrettladley
Copy link
Member

also @DOOduneye, is the tab autocomplete working or should we open an issue to track that feature?

@DOOduneye
Copy link
Contributor Author

also @DOOduneye, is the tab autocomplete working or should we open an issue to track that feature?

im going to make an issue, i thought it was as simple as sac completion zsh > /tmp/completion but that doesn't work

@DOOduneye
Copy link
Contributor Author

some nits my 👑 also, should these frontend changes be in a diff PR? or are they as a result of formatting/linting with the updated CLI?

frontend changes come from running and testing the cli

@DOOduneye DOOduneye merged commit 91fac39 into main Apr 28, 2024
@DOOduneye DOOduneye deleted the cli-refactor branch April 28, 2024 22:14
@DOOduneye DOOduneye linked an issue May 2, 2024 that may be closed by this pull request
feat: CLI CI #543
Open
2 tasks
@DOOduneye DOOduneye removed a link to an issue May 2, 2024
feat: CLI CI #543
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettladley garrettladley garrettladley requested changes

Assignees

@DOOduneye DOOduneye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ci
2 participants
@DOOduneye @garrettladley