Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rich text editor #996

Merged
merged 3 commits into from
Jun 11, 2024
Merged

feat: rich text editor #996

merged 3 commits into from
Jun 11, 2024

Conversation

in-mai-space
Copy link
Contributor

@in-mai-space in-mai-space commented Jun 11, 2024 •
edited
Loading

Description

Rich text editor.

How Has This Been Tested?

No tests

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@in-mai-space in-mai-space self-assigned this Jun 11, 2024
@garrettladley garrettladley requested review from a team, DOOduneye and garrettladley and removed request for a team June 11, 2024 06:19
garrettladley
garrettladley reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits then LGTM to merge @in-mai-space

frontend/dashboard/src/components/dashboard/bubbleMenu.tsx Fixed Show resolved Hide resolved
frontend/dashboard/src/components/dashboard/toolbar.tsx Fixed Show resolved Hide resolved
garrettladley
garrettladley approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good sheet @in-mai-space

@garrettladley garrettladley merged commit 254df35 into main Jun 11, 2024
5 checks passed
@garrettladley garrettladley deleted the text-editor branch June 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettladley garrettladley garrettladley approved these changes

@DOOduneye DOOduneye Awaiting requested review from DOOduneye DOOduneye was automatically assigned from GenerateNU/sac-tls

Assignees

@in-mai-space in-mai-space

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@in-mai-space @garrettladley