Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete ws connection alert after reconnection #723

Closed
wants to merge 2 commits into from

Conversation

hhaensel
Copy link
Member

@hhaensel hhaensel commented Nov 6, 2024

This PR fixes #722

@hhaensel
Copy link
Member Author

hhaensel commented Nov 6, 2024

Details of the fix

  • at the top of the page a row of the size of the alert-message is inserted to avoid that any content is covered
  • the alert message is displayed at the top of the screen and doesn't move
  • webchannels_alert_overlay (false) controls whether the spacer at the top is inserted (true means no spacer)
  • webchannels_show_alert (true) controls whether the message is displayed
  • GENIEMODEL.ws_disconnected is set if GENIEMODEL is defined so if people want a personalised alert message, they can set Genie.config.webchannels_show_alert = false and add any content with @if(:ws_disconnected)

@essenciary
Copy link
Member

Thanks @hhaensel Let me try it out today - I'll probably backport into v0.28 and test there.

@hhaensel
Copy link
Member Author

hhaensel commented Nov 7, 2024

Has been cherrypicked into master with some fixes, so we close it here

@hhaensel hhaensel closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make websocket diconnection alert more flexible and automatically clear upon reconnection
2 participants