Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing metadata per layer in map #1616

Closed
gannebamm opened this issue Nov 14, 2023 · 9 comments · Fixed by #1661
Closed

Showing metadata per layer in map #1616

gannebamm opened this issue Nov 14, 2023 · 9 comments · Fixed by #1661
Assignees
Labels
enhancement New feature or request feature

Comments

@gannebamm
Copy link

Problem: When I, as a viewer, look at a map with multiple data layers, I do not get detailed information about the layers used in the map without leaving it. So far, I can look at the map, but this jumps to the respective data set and the map is exited.

grafik

Objective: As a viewer, I would like to be able to display the detail panel of the layer on the right-hand side via an additional layer on the right side. For this, I do not leave the map view. A mockup is shown in the following figure.

grafik

@gannebamm gannebamm added enhancement New feature or request feature labels Nov 14, 2023
@gannebamm gannebamm self-assigned this Nov 14, 2023
@gannebamm
Copy link
Author

Thünen has worked on that idea and provides a PR solution here: Thuenen-GeoNode-Development#22

If this is interesting for a general audience we will upstream the feature

@gannebamm
Copy link
Author

@allyoucanmap @giohappy Do you think this is interesting for a wider audience and shall we prepare a proper PR for this?

@giohappy
Copy link

@gannebamm looks interesting and useful indeed!
Yes please open a PR. However, I cannot guarantee we will be able to have a look soon, since we're closing for Christmas.

@giohappy
Copy link

@gannebamm any chance to take a look at the code (PR) for this feature?

@ridoo
Copy link

ridoo commented Mar 15, 2024

@giohappy we have regression with this since v4.2.2: The linked resources have to be mapped now (as it is done in the DetailViewer). The point here is, that the linked resources endpoint is only available on /resources but not /datasets which includes the attribute_set rendered in the Attributes tab. @ahmdthr is figuring out how to deal with this .. for example, if making a second request to /datasets would be needed (which is not very nice solution TBH).

@gannebamm
Copy link
Author

@giohappy I know it is not a PR and not tracking master, but the latest code @ahmdthr has done is listed here: https://github.com/Thuenen-GeoNode-Development/geonode-mapstore-client/pull/22/files

As @ridoo said there are still some issues. Shall we create a draft PR?

@ridoo
Copy link

ridoo commented Mar 19, 2024

@gannebamm I am doing a re-test as @ahmdthr says, it works on his machine. However, AFAIK the linked_resources endpoint is only available for resources, not datasets. Maybe I am overlooking something ...

Edit: And he is right :) .. the mapstore-client is doing requests on both endpoints /resources and /datasets. I will merge the regression he fixed.

@giohappy
Copy link

giohappy commented Mar 22, 2024

@ridoo @gannebamm I invite you to keep this on hold for a few hours. We're about to merge a GeoNode/geonode#12080 that will optionally include linked_resources inside the response for all the resources endpoints if ?include[]=linked_resources is used.
This was done to avoid having to do too many additional requests (that will particularly affect the new development for the mapviewers)

@gannebamm
Copy link
Author

We will start working on this again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants