Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to “[email protected]” failed on Windows #477

Closed
underdpt opened this issue Oct 1, 2019 · 8 comments
Closed

Updating to “[email protected]” failed on Windows #477

underdpt opened this issue Oct 1, 2019 · 8 comments

Comments

@underdpt
Copy link

underdpt commented Oct 1, 2019

When upgrading to latest php-ide-serenata v5.0.0 it throws an error in windows, due to the command rm being used (but it doesn't exists on windows):

npm ERR! prepareGitDep 1> 
npm ERR! prepareGitDep > [email protected] prepare C:\Users\user\.atom\.apm\_cacache\tmp\git-clone-5d2a9ffc
npm ERR! prepareGitDep > npm run clean && npm run compile
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 
npm ERR! prepareGitDep > [email protected] clean C:\Users\user\.atom\.apm\_cacache\tmp\git-clone-5d2a9ffc
npm ERR! prepareGitDep > rm -rf build
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 2> npm WARN install Usage of the `--dev` option is deprecated. Use `--only=dev` instead.
**npm ERR! prepareGitDep "rm" no se reconoce como un comando interno o externo,**
npm ERR! prepareGitDep programa o archivo por lotes ejecutable.
npm ERR! prepareGitDep npm ERR! code ELIFECYCLE
npm ERR! prepareGitDep npm ERR! errno 1
npm ERR! prepareGitDep npm ERR! [email protected] clean: `rm -rf build`
npm ERR! prepareGitDep npm ERR! Exit status 1
npm ERR! prepareGitDep npm ERR! 
npm ERR! prepareGitDep npm ERR! Failed at the [email protected] clean script.
npm ERR! prepareGitDep npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

The resalted line says "rm" is not recognized as an external or internal command.

@uzuzoo
Copy link

uzuzoo commented Oct 1, 2019

Same Issue as @underdpt

@UziTech
Copy link
Contributor

UziTech commented Oct 1, 2019

atom/atom-languageclient#276 should fix it

@Gert-dev
Copy link
Owner

Gert-dev commented Oct 1, 2019

This does appear to be an issue with the atom-languageclient package.

As a workaround, you may be able to fix this by removing the php-ide-serenata package folder first and then reinstalling. In that case it may skip trying to remove the previous directory.

Once the pull request is merged in atom-languageclient, I'll try targeting the unstable commit to fix the problem here as well - at least if it doesn't break anything else, so I'll leave this open.

@underdpt
Copy link
Author

underdpt commented Oct 2, 2019

Thanks @Gert-dev

Removing the package and package folder didn't help (also tried removing the atom-languageclient folder). Will wait for the fix.

@putude
Copy link

putude commented Oct 5, 2019

FYI, Same problem here. Using Win 10 64bit.

  • uninstall and remove the serenata folder = did not work.
  • install rimraf = did not work.
    back to v 4.5.3 and waiting for the fix.
    serenata is awesome!!

@Gert-dev
Copy link
Owner

Gert-dev commented Oct 8, 2019

Another workaround that you can try is (in your Atom packages folder):

  • git clone https://github.com/Gert-dev/php-ide-serenata.git.
  • Open package.json and change this line "atom-languageclient": "github:atom/atom-languageclient#3d92c060e0a1b9558a392f5fba674dc707b4528e", to "atom-languageclient": "^0.9.9",.
  • Run apm install in the php-ide-serenata folder.

This will likely fix it, but you will likely run into an issue where autocompleting e.g. @inher will result in @@inheritDoc.

I'm now wondering if I shouldn't just revert to that in master; the issue of not being able to install is probably worse than the autocompletion bug.

@UziTech
Copy link
Contributor

UziTech commented Oct 8, 2019

I agree, especially since it seems atom has no intention of releasing a new version of atom-languageclient any time soon.

The other solution could be forking atom-languageclient and using your own fork until they decide to fix it in the main repo.

@Gert-dev
Copy link
Owner

Gert-dev commented Oct 9, 2019

Alright, I'm going to revert to 0.9.9. I've created #487 to track the issue it reintroduces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants