Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator causes layout jumps #577

Closed
ilyakonrad opened this issue Apr 1, 2024 · 2 comments · Fixed by #624
Closed

Loading indicator causes layout jumps #577

ilyakonrad opened this issue Apr 1, 2024 · 2 comments · Fixed by #624
Labels

Comments

@ilyakonrad
Copy link

Hoopit-GoogleChrome2024-04-0113-30-17-ezgif.com-video-to-gif-converter.mp4

It's easily fixable with CSS

.str-chat__message-list-scroll {
  // Make room for the loading indicator.
  padding-top: 20px !important;

  stream-loading-indicator {
    // Avoid UI shift.
    height: 0;
    display: block;
    // Move it on the parent's top padding.
    translate: 0 -16px;
  }
}

P. S. Also weird that the scroll up triggers loading every time even after you loaded everything already.

@szuperaz
Copy link
Contributor

szuperaz commented Apr 2, 2024

I can't play the video, but I think I know what you mean.

The problem is that since the loading indicator can be customized, we'd most likely need to use CSS variables to solve this issue, so I don't think it will be solved in the near future.

As for loading is triggered after everything is loaded: that will be solved as part of this issue: #566

Copy link

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants