Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix voice recording view layout and colors #689

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Fix voice recording view layout and colors #689

merged 7 commits into from
Dec 11, 2024

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Dec 10, 2024 •
edited
Loading

🔗 Issue Link

IOS-604

🎯 Goal

Message of the voice recording should be outside of the recording view. Background colors were off as well.

🧪 Testing

N/A

🎨 Changes

Before After
before-light-2 after-light-2
before-dark-2 after-dark-2

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner December 10, 2024 14:19
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 10, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.53 MB 7.53 MB 0 KB 🟢

@laevandus laevandus mentioned this pull request Dec 10, 2024
Closed
4 tasks
@laevandus laevandus changed the title Fix voice recording view layout [WIP] Fix voice recording view layout and colors Dec 10, 2024
@nuno-vieira
Copy link
Member

Just added a few comments 👍 We will need to re-record the snapshot tests as well

@laevandus laevandus changed the title [WIP] Fix voice recording view layout and colors Fix voice recording view layout and colors Dec 11, 2024
martinmitrevski
martinmitrevski approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but there are some test failures to check before merging

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
44.9% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit a58e648 into develop Dec 11, 2024
11 of 12 checks passed
@laevandus laevandus deleted the fix/voice-recording-layout branch December 11, 2024 12:29
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

@nuno-vieira nuno-vieira Awaiting requested review from nuno-vieira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laevandus @Stream-SDK-Bot @nuno-vieira @martinmitrevski