Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-3941] Fix event deserialization issues #1106

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Jun 5, 2024

🎯 Goal

Deserialization error is printed in the logs multiple times when a received event could not be mapped with one of our classes. The CoordinatorSocket.onMessage() deserialization logic needs to be refactored.

Patreon Zendesk ticket here.

🛠 Implementation details

  • Added UnsupportedVideoEventException to separately handle the "cannot map with class" case.
  • Added handling for ConnectionErrorEvent and removed SocketError handling. We never get a message that can be mapped to SocketError with field error. ❓
  • Added transcription event classes.

🧪 Testing

  • Check CoordinatorSocket.onMessage().
  • Run app and follow logs.
  • Check OpenAPI specs to confirm that trying to map to SocketError is not good.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

@liviu-timar liviu-timar marked this pull request as ready for review June 10, 2024 12:20
@liviu-timar liviu-timar requested a review from a team as a code owner June 10, 2024 12:20
@aleksandar-apostolov
Copy link
Collaborator

Resolve merge conflicts before merging, otherwise OK

@liviu-timar liviu-timar force-pushed the PBE-3941-serialisation-issues-fixes branch from 6238de2 to d44d256 Compare June 11, 2024 13:17
@aleksandar-apostolov aleksandar-apostolov merged commit e605226 into develop Jun 11, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the PBE-3941-serialisation-issues-fixes branch June 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants