[PBE-3941] Fix event deserialization issues #1106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Deserialization error is printed in the logs multiple times when a received event could not be mapped with one of our classes. The
CoordinatorSocket.onMessage()
deserialization logic needs to be refactored.Patreon Zendesk ticket here.
🛠 Implementation details
UnsupportedVideoEventException
to separately handle the "cannot map with class" case.ConnectionErrorEvent
and removedSocketError
handling. We never get a message that can be mapped toSocketError
with fielderror
. ❓🧪 Testing
CoordinatorSocket.onMessage()
.SocketError
is not good.☑️Contributor Checklist
General
develop
branch☑️Reviewer Checklist