Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call reconnection issue #1217

Closed
wants to merge 4 commits into from
Closed

Fix call reconnection issue #1217

wants to merge 4 commits into from

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Oct 30, 2024 •
edited
Loading

🎯 Goal

Fix issue when call reconnects indefinitely when connectivity breaks and is restored.

🛠 Implementation details

  • Changed Call#handleSignalChannelDisconnect to enable rejoin retries.
  • Generating a new session id and using the client impl as a source of truth for it.

🧪 Testing

  • Livestream
  • Normal call

@liviu-timar liviu-timar marked this pull request as ready for review October 30, 2024 10:42
@liviu-timar liviu-timar requested a review from a team as a code owner October 30, 2024 10:42
@aleksandar-apostolov
Copy link
Collaborator

This is updated in the reconnect V2 PR. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviu-timar @aleksandar-apostolov