Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shapes should be replaced with more efficient versions used in carpet /draw #40

Open
Firigion opened this issue Jan 25, 2021 · 8 comments · May be fixed by #94
Open

Shapes should be replaced with more efficient versions used in carpet /draw #40

Firigion opened this issue Jan 25, 2021 · 8 comments · May be fixed by #94
Assignees
@Ghoulboy78
Labels
enhancement New feature or request requires carpet pr Waiting on a pr in Fabric Carpet
Milestone
v1.4.0

Comments

@Firigion
Copy link
Collaborator

That's about it.
@Firigion Firigion added the enhancement New feature or request label Jan 25, 2021
@Ghoulboy78
Copy link
Owner

k thx. ngl tho, it's not like the current carpet /draw commands are record-breakers for speed...

@Ghoulboy78
Copy link
Owner

but they're significantly better than the brush stuff.

@Firigion
Copy link
Collaborator Author

Yeah, the brush stuff is literally "check every block if it's inside, set it". And the check to see if it's inside is not even that good.

@altrisi
Copy link
Collaborator

altrisi commented Jan 25, 2021

Relates to gnembon/fabric-carpet#637.

Although that one is blocked by gnembon/fabric-carpet#618.

@Ghoulboy78 Ghoulboy78 added this to the v1.3.0 milestone Jan 27, 2021
@Ghoulboy78
Copy link
Owner

This is a work in progress

@Ghoulboy78
Copy link
Owner

Ghoulboy78 commented Feb 1, 2021 •
edited
Loading

I'll add once gnembon/fabric-carpet#618 is accepted.

@Ghoulboy78 Ghoulboy78 mentioned this issue Feb 3, 2021
Closed
@Ghoulboy78
Copy link
Owner

ok now this depends on gnembon/fabric-carpet#742

@Ghoulboy78 Ghoulboy78 modified the milestones: v1.3.0, v1.4.0 Mar 21, 2021
@Ghoulboy78 Ghoulboy78 added the requires carpet pr Waiting on a pr in Fabric Carpet label Apr 18, 2022
@Ghoulboy78 Ghoulboy78 linked a pull request Apr 18, 2022 that will close this issue
Updating shapes to use shapes.scl and fix some minor things #94
Open
@Ghoulboy78
Copy link
Owner

ok now this depends on gnembon/fabric-carpet#1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ghoulboy78 Ghoulboy78

Labels
enhancement New feature or request requires carpet pr Waiting on a pr in Fabric Carpet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Updating shapes to use shapes.scl and fix some minor things Ghoulboy78/Scarpet-edit
3 participants
@altrisi @Ghoulboy78 @Firigion