Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flood, drain, hollow and outline use cartesian neighbors #64

Open
Firigion opened this issue Mar 21, 2021 · 0 comments
Open

Flood, drain, hollow and outline use cartesian neighbors #64

Firigion opened this issue Mar 21, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Firigion
Copy link
Collaborator

Flood, drain, hollow and outline only check for direct cartesian neighbors (the six blocks in the positive and negative offset along the axes). This is fine for most cases, but it produces counter intuitive results in some cases. Particularly in cases where an outline brush is meant to be applied multiple times to give a thicker outline: the second application doesn't work properly, since the outline placed by the app is not considered as a "block of blocks" (they connect only diagonally in some cases).

I think the best solution for this will be adding a new flag that affects all functions that check neighbors, maybe a -n flag? Naming is hard.

@Firigion Firigion added the enhancement New feature or request label Mar 21, 2021
@Firigion Firigion self-assigned this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant