Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: creating component RoundColor #377

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LucaMaggioli
Copy link
Contributor

@LucaMaggioli LucaMaggioli commented May 20, 2021

Description

Creating a component to make a round color
proprs:

  • width: number;
  • color: string;
  • isSelected: boolean;
  • disabled?: boolean;
  • onClick: () => void;

RESOLVE #353

Checklist

  • My Pull Request point to sprint branch
  • I move my Issue to Review in progress
  • I add tests if necessary.

@LucaMaggioli LucaMaggioli added the 🚀frontend Pour le Fronted React ☸️ label May 20, 2021
@LucaMaggioli LucaMaggioli added this to the sprint-7 milestone May 20, 2021
@LucaMaggioli LucaMaggioli self-assigned this May 20, 2021
Copy link
Member

@Melvynx Melvynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le but de faire ce composant c'est ensuite pour l'utiliser dans RandomColor et PreciseColorPicker

disabled,
onClick,
}: RoundColorProps) {
const disabledColor = theme.palette.action.disabled;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const disabledColor = theme.palette.action.disabled;
const theme = useTheme();
const disabledColor = theme.palette.action.disabled;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le but de faire ce composant c'est ensuite pour l'utiliser dans RandomColor et PreciseColorPicker

Yes mais je ne savais pas si le componant allais bien, du coups c'est pour ça que je l'ai mis en Draft, du coups je l'applique à RandomColor et PreciseColorPicker

@Melvynx Melvynx linked an issue May 24, 2021 that may be closed by this pull request
Base automatically changed from sprint-7 to master May 24, 2021 20:04
@villou villou changed the base branch from master to sprint-8 May 24, 2021 20:07
@villou villou removed this from the sprint-7 milestone May 24, 2021
Base automatically changed from sprint-8 to master June 14, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀frontend Pour le Fronted React ☸️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homogène des "Rond" pour la couleur
3 participants