Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GiphyDialogFragment's list not playing all frames delays #164

Open
perracodex opened this issue Nov 2, 2021 · 1 comment
Open

GiphyDialogFragment's list not playing all frames delays #164

perracodex opened this issue Nov 2, 2021 · 1 comment

Comments

@perracodex
Copy link

perracodex commented Nov 2, 2021

Just by chance while testing different GIFs, I've found one which has all frames with a delay at 80ms, except for the last frame which is set to 480ms.
In Giphy's web site the GIF in question plays correctly including taking into account the last frame delay, yet in the GiphyDialogFragment's list seems the last frame delay is ignored giving the impression that it animates faster.

The actual GIF is next:

https://giphy.com/gifs/imoji-laughing-3ohzdQJJ2JGvMSYvdu

Although is a minimal issue, I wanted to point it out just in case.

Update:
Found a few more GIFs where the last frame has a longer delay, but the dialog preview doesn't honor it.
This one has a 0 delay per frame and a the last with with 3000ms. The GiphyDialogFragment correctly assumes 100ms for the 0 delay frames, yet it ignores the last 3000ms frame. Giphy's webside honors the delay:

https://giphy.com/stickers/cedars-sinai-transparent-abizFdsnUSFfa5qOEm

@ALexanderLonsky
Copy link
Collaborator

hey @perracolabs, thanks for flagging this.
As you may already know, Giphy SDK uses Facebook Fresco under the hood. It must be an option to take into account the frames' delay.
I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants