Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD Pipeline #24

Open
Rikuoja opened this issue Oct 19, 2021 · 1 comment
Open

CI/CD Pipeline #24

Rikuoja opened this issue Oct 19, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Rikuoja
Copy link
Collaborator

Rikuoja commented Oct 19, 2021

Would be nice to have a simple GitHub pipeline with at least one test (e.g. does the service start)?

(Would be even nicer if the pipeline builds the notebook docker image, but that is not necessary, since most changes atm are in the Flask app.)

The Flask app is mounted and installed on a standard flask image, so no building happens there at the moment. But perhaps we want to build an image properly too at some point, instead of doing everything at service startup?

@Rikuoja Rikuoja added the enhancement New feature or request label Oct 19, 2021
@Rikuoja
Copy link
Collaborator Author

Rikuoja commented Nov 9, 2021

A partial pipeline is in action. Docker images are built automatically.

However, there is no pre-commit (see #32) and no tests on the container, so we don't know whether flask will actually start or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants