Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move map generation functions from ipygis #51

Open
Rikuoja opened this issue Jan 27, 2022 · 0 comments
Open

Move map generation functions from ipygis #51

Rikuoja opened this issue Jan 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Rikuoja
Copy link
Collaborator

Rikuoja commented Jan 27, 2022

Is your feature request related to a problem? Please describe.
Currently, the Kepler map htmls are directly generated by https://github.com/gispoCoding/ipygis . That won't do if we want our own custom Kepler instance here (#49). Also, ipygis might be deprecated anyway. We want to be able to create the right kind of Kepler map config and the geodataframes for our Kepler instance.

Describe the solution you'd like
Move all the code required by generate_map to this repo. Instead of a Kepler map html, generate_map should return a Kepler config json with the geodataframe embedded, or alternatively, generate the config and the geodataframes and let Flask serve them to Kepler separately.

Also, tests are necessary. Currently, generate_map is far too fragile.

@Rikuoja Rikuoja added the enhancement New feature or request label Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant