Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sadly we were unable to get the exchange rate! #2543

Open
RamRamez opened this issue Sep 23, 2021 · 5 comments
Open

Sadly we were unable to get the exchange rate! #2543

RamRamez opened this issue Sep 23, 2021 · 5 comments
Assignees
Labels
bug Issues that arise due to code architecture

Comments

@RamRamez
Copy link
Collaborator

RamRamez commented Sep 23, 2021

Always getting this error on develop, but it's ok on trace.giveth.io

image

@RamRamez
Copy link
Collaborator Author

In trace.giveth.io it's ok, but when I use master branch with develop backend, I get same error.
It seems it's related to backend. @mohammadranjbarz Can you check it?

@mohammadranjbarz
Copy link
Collaborator

Always getting this error on develop, but it's ok on trace.giveth.io

This issue is also a blocker for issue #2544

image

@RamRamez
Are you getting this error now?
I can't reproduce it

@RamRamez
Copy link
Collaborator Author

RamRamez commented Sep 26, 2021

@mohammadranjbarz Yes I'm still getting it.
My profile token is DAI and convertMultipleRates doesn't give current balance value of Trace in DAI

image

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 27, 2021

@mohammadranjbarz Yes I'm still getting it.
My profile token is DAI and convertMultipleRates doesn't give current balance value of Trace in DAI

image

@RamRamez Ok Gotcha, the DAI is not in token whitelist in develop , so you get error, in develop environment you should not allow user to select DAI user can select XDAI
please see our token whitelist in develop
https://feathers.develop.giveth.io/whitelist

Screen Shot 1400-07-05 at 11 07 12

but it's not good that we don't return the appropriate error message on the backend

@mohammadranjbarz
Copy link
Collaborator

@mohammadranjbarz Yes I'm still getting it.
My profile token is DAI and convertMultipleRates doesn't give current balance value of Trace in DAI
image

@RamRamez Ok Gotcha, the DAI is not in token whitelist in develop , so you get error, in develop environment you should not allow user to select DAI user can select XDAI
please see our token whitelist in develop
https://feathers.develop.giveth.io/whitelist

Screen Shot 1400-07-05 at 11 07 12

but it's not good that we don't return the appropriate error message on the backend

@RamRamez
Sorry my mistake., I think it's a bug in the backend, I should have return results for native currency list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that arise due to code architecture
Projects
None yet
Development

No branches or pull requests

2 participants