Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default project image urls are hardcoded #261

Open
RamRamez opened this issue Sep 25, 2021 · 1 comment
Open

Default project image urls are hardcoded #261

RamRamez opened this issue Sep 25, 2021 · 1 comment
Assignees
@RamRamez
Labels
bug Something isn't working

Comments

@RamRamez
Copy link
Collaborator

We should always insert urls in image property, not numbers.

It makes App buggy, like:

Giveth/giveth-dapp#2546

image
@RamRamez RamRamez self-assigned this Sep 25, 2021
@RamRamez RamRamez mentioned this issue Sep 25, 2021
Open
@MoeNick MoeNick added the bug Something isn't working label Oct 18, 2021
RamRamez added a commit that referenced this issue Oct 25, 2021
@RamRamez
H #261 fix default image urls
861ff98
@RamRamez RamRamez mentioned this issue Oct 25, 2021
Merged
@mohammadranjbarz
Copy link
Collaborator

@divine-comedian
It's a refactoring task, but you can create a project with default images and then in the playground you can get projectInfo and you should see a pinata link as image ( before this task it was a number instead of link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RamRamez RamRamez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mohammadranjbarz @RamRamez @MoeNick