Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_crs and set_transform to force re-set geospatial attributes? #567

Open
rhugonnet opened this issue Jun 12, 2024 · 3 comments · May be fixed by #446
Open

Add set_crs and set_transform to force re-set geospatial attributes? #567

rhugonnet opened this issue Jun 12, 2024 · 3 comments · May be fixed by #446
Labels
enhancement Feature improvement or request priority

Comments

@rhugonnet
Copy link
Contributor

Mirroring gpd.GeoDataFrame.set_crs()

@rhugonnet
Copy link
Contributor Author

Update on this: our crs and transform properties already have a data.setter, so it's only about the way of setting: using set_xxx instead of raster.xxx = new_xxx...
Not sure what's best.

@rhugonnet
Copy link
Contributor Author

A note also that our current set_ functions (nodata, mask, area_or_point) are all inplace without option, while GeoPandas' set functions are not inplace (but with an argument).

@adehecq
Copy link
Member

adehecq commented Jun 13, 2024

Mmmh, both good points... Although I find it more intuitive to do e.g. rst.nodata = -9999 than rst = rst.set_nodata(-9999), it's also a good idea to match geopandas syntax. After all, there are many more geopandas users than geoutils users at the moment, and if we want to make their life easier, it's the best we can do!

@rhugonnet rhugonnet linked a pull request Nov 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants