Update HLS chunk regex (#1918)

GladysAssistant · Oct 30, 2023 · f4d2228 · f4d2228
1 parent 797d09c
commit f4d2228
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/server/services/rtsp-camera/utils/validateStreamParams.js b/server/services/rtsp-camera/utils/validateStreamParams.js
@@ -10,7 +10,7 @@ const validateSessionId = (sessionId) => {
 };
 
 const AUTHORIZED_FILENAMES = ['index.m3u8', 'index.m3u8.key', 'key_info_file.txt'];
-const HLS_CHUNK_REGEX = /index[0-9]+.ts/;
+const HLS_CHUNK_REGEX = /^index[0-9]+.ts$/;
 
 const validateFilename = (filename) => {
   if (AUTHORIZED_FILENAMES.includes(filename)) {

diff --git a/server/test/services/rtsp-camera/controllers/rtspCamera.controller.test.js b/server/test/services/rtsp-camera/controllers/rtspCamera.controller.test.js
@@ -178,6 +178,21 @@ describe('camera controller test', () => {
     );
     await chaiAssert.isRejected(promise, 'Invalid filename');
   });
+  it('should return 400, bad request, invalid filename', async () => {
+    const rtspCameraController = RtspCameraController(gladys, rtspCameraService);
+    const req = {
+      params: {
+        folder: 'camera-1',
+        file: '`index1.tslala',
+      },
+    };
+    const resWriteStream = {};
+    const promise = rtspCameraController['get /api/v1/service/rtsp-camera/camera/streaming/:folder/:file'].controller(
+      req,
+      resWriteStream,
+    );
+    await chaiAssert.isRejected(promise, 'Invalid filename');
+  });
   it('should return 400, bad request, invalid session id', async () => {
     const rtspCameraController = RtspCameraController(gladys, rtspCameraService);
     const req = {