Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Add support for subdomains in the website field of a password in passy #111

Open
1 task done
promitheas17j opened this issue Jun 12, 2024 · 4 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request next release Will be resolved before next release

Comments

@promitheas17j
Copy link

Suggestion

Hello again! I'd like to preface this issue by saying this is not something urgent, or something I (and I assume others) can't live without, but it is a thought that I've been having recently and having the option to add subdomains for a passy password if the login details are the same across all subdomains would be nice. This is just an idea and if it's something you don't feel like spending critical dev time on I 100% get it :)

I personally feel like it would be nice to add support for subdomains in some way when creating/editing a passy password's website field. Currently what I do is create a custom field with Website 2 or Website n and put the subdomain in there, but this does not have the functionality of the original Website field of visiting the link.

I'll use the archlinux.org subdomains of bbs and aur as an example. Login credentials are the same for these, so instead of creating separate password entries for each it logically makes sense to me to have them be in a single Passy Password. The 2 example links are bbs.archlinux.org for the forums and aur.archlinux.org for the AUR package page.

Off the top of my dome this could be implemented by creating an entirely new field called subdomain and listing each in separate fields of this type (when visiting any of these automatically the app would derive the correct url), or by clicking a button somewhere next to the Website field which will allow you to add a new copy of the website field and change the actual link it contains.

Many thanks for the great app!

Submission checklist

  • I have specified my suggestion in the issue title
@promitheas17j promitheas17j added the enhancement New feature or request label Jun 12, 2024
@GleammerRay
Copy link
Collaborator

Hello @promitheas17j !

This is a reasonable request, I will consider adding support for multiple websites for the next update.

I'm planning to include an optional "Website 2" field under the website field, and when that is filled, optional "Website 3" field will appear, and so on.

I don't feel like modifying the password data structure for this, so I'm probably just going to append to the website field, separated by newlines, and then split those into separate entries in the UI.

Cheers!

@promitheas17j
Copy link
Author

Sounds good! Your way does sound a lot better now I think about it.

Cheers for the quick reply once again :)

@GleammerRay GleammerRay added the next release Will be resolved before next release label Jun 13, 2024
@GleammerRay
Copy link
Collaborator

GleammerRay commented Jun 13, 2024

image

Screenshot_20240613_125439

Screenshot_20240613_125508

This feature has been implemented and will be present in the next release. Feel free to request any adjustments. Thanks a lot for your suggestion!

@promitheas17j
Copy link
Author

It's looking great! That was quick wow :D

I'll be sure to test it out as soon as it goes live and let you know should there be any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release Will be resolved before next release
Projects
None yet
Development

No branches or pull requests

2 participants