Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI UX Improvement? #13

Open
heysupratim opened this issue Nov 15, 2022 · 7 comments
Open

UI UX Improvement? #13

heysupratim opened this issue Nov 15, 2022 · 7 comments
Labels
discussion A non-feature specific discussion enhancement New feature or request question Further information is requested UI

Comments

@heysupratim
Copy link

Hi @GleammerRay

The app works great. Thanks for your work.

I have been wanting to contribute to some newish open source projects that could benefit from a design revamp/improvement. I am a ui/ux designer by the day and have been wanting to contribute towards better looking open source design?

Do you think there is anything you need help on?

@GleammerRay
Copy link
Collaborator

GleammerRay commented Nov 15, 2022

Hey @heysupratim !
Glad to know that you like this project.

I'm not entirely sure about what can be done with UI, as to me at the moment it seems technically functional and, at a certain level, intuitive.

I have one issue with the UI being jittery on Linux (and perhaps other systems) when a video or an animation is playing elsewhere, but I'm unsure if it can be fixed, since it might just be a rendering issue, I have seen similar thing happen to Discord.

Looking at UX, I believe that the UI is alright, but it could use a little bit more flexibility across different screen sizes in some places, however nothing specific that I have in mind. Only place where breakpoints exist is the main screen, see #6 .

When it comes to light theme, I have that feature planned for some time in the future, but I don't think that it's critically important. If it was to be implemented, then I would prefer having dark/light theme being set for different accounts.

Let me know what you think, and if you feel like there's something else that can be improved. Many thanks!

@GleammerRay GleammerRay added question Further information is requested enhancement New feature or request labels Nov 15, 2022
@heysupratim
Copy link
Author

heysupratim commented Nov 15, 2022

Thanks for the wonderfully detailed reply. The app surely is greatly functional and i feel we shouldnt change much of the UX if the users are already used to it but how about making it seem a little bit more modern grid individual element.

image

image

@GleammerRay
Copy link
Collaborator

GleammerRay commented Nov 16, 2022

Sure thing, I wouldn't mind having a UI with slightly more screen adaptability. Perhaps without the big banners, but having more columns depending on the screen could be nice (maybe similarly to how it works on the main screen).

As a side note, making buttons with more height for wider screens could indeed allow space for a three dot button that could allow opening a website and copying username/password, so that could be an appealing addition.

The credit cards UI is of course begging for breakpoints, I just haven't come around to fix it yet.

@philipp-reinhardt
Copy link
Contributor

philipp-reinhardt commented Nov 29, 2022

Hi, I also want to say thank you for your OS contribution. I'm currently using an online password manager because of the ease of syncing passwords. Yesterday I stumbled across your app and must say I like it so far.
I didn't use it much, but regarding UI/UX there is something that came to my mind (android):

  • [see Reduce depth of menus #15] sometimes it's too many submenus to achieve a task, for example to set up a backup:
    Settings -> backup and restore -> backup -> passy backup
    it's not necessarily the amount of steps, but some views show just one menu-item and thus could be dropped

  • [see Quick search for passwords #16] similarly, searching for specific passwords has more actions involved as I'm used to

  1. choose subgroup (passwords for example)
  2. press magnifier
  3. type text and choose item
    I think at least step 1 and 2 could be dropped by having a search box on the main view
    The same goes for the way back. So in case you want to copy and paste multiple passwords one after the other, you need to go all steps back, instead of going directly to the main screen.
  • [see Reduce chance of accidental logouts #17] Pressing the back-key too many times brings you back to the login screen. This doesn't feel very intuitive to me. Following the screen design, the topleft arrow makes me feel I'm not in the main view and when I press back I'm in the login view.

  • [see Missing trigger for biometric authentication #18] When being in the login view, there is no button to launch biometric authentication and I'm stuck. I need to type in my PW or to kill the app just to reopen it. In case the user with enabled biometric authentication is the default selected one, it will show the prompt. If not, I'm still stuck.

These are just a few impressions and are my personal opinion. If you are interested into discussing some of my points, I'm happy to do so.

Thanks

@GleammerRay
Copy link
Collaborator

Woah @philipp-reinhardt ! These suggestions sound great.

sometimes it's too many submenus to achieve a task

I wonder how I left this unnoticed. 🤔

The Passy backup/restore menus will be made easier to access, I don't know what I was thinking, maybe the idea of multiple types of exports was interrupting my process.

searching for specific passwords has more actions involved as I'm used to

It would indeed be great to have a general purpose search on the main screen, I'll see what I can do.

Pressing the back-key too many times brings you back to the login screen

It seems reasonable to change the main screen back icon to a different icon and implement a popup that would allow to confirm the log out in case of accidental back press.

no button to launch biometric authentication

Ahh, this is a must! I did feel like something was missing on the login screen, thanks to your reply I finally know that it was the bio auth button. While you do not need to kill the app to get the bio auth prompt, currently it can be achieved far more easily by switching to a different app and then back to Passy, but that's not intuitive nor easy and should actually accompany the bio auth button rather than replace it.

Please do tell me if my attention missed any detail, and thanks a lot!

@philipp-reinhardt
Copy link
Contributor

Hi, thanks for coming back and considering my points.

Pressing the back-key too many times brings you back to the login screen

It seems reasonable to change the main screen back icon to a different icon and implement a popup that would allow to confirm the log out in case of accidental back press.

I would like to propose to disable back-key for the main-screen completey (or if really wanted, to do a toast "press two times to close / go back"). Instead, or additionally to such a toast, a "logout" / "switch user" button could be added to the top-menu-bar

no button to launch biometric authentication

Ahh, this is a must! I did feel like something was missing on the login screen, thanks to your reply I finally know that it was the bio auth button. While you do not need to kill the app to get the bio auth prompt, currently it can be achieved far more easily by switching to a different app and then back to Passy, but that's not intuitive nor easy and should actually accompany the bio auth button rather than replace it.

Thanks for that hint. Indeed, that makes it easier.

Please do tell me if my attention missed any detail, and thanks a lot!

There are some other things I was thinking about, but in general I think it might be a good idea to add each point as separate issue to this project to be able to track them individiually. If I find time today, I'll try to split.
Although I don't use flutter/Dart often, I might be able to invest some time to support by taking over smaller tasks.
Need to sort out some SDK issues on my side first

Cheers

@GleammerRay
Copy link
Collaborator

GleammerRay commented Nov 30, 2022

Alright then. It would be incredibly helpful if you could provide some assistance with UI. And please do add the other issues you have in mind if you can, that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion A non-feature specific discussion enhancement New feature or request question Further information is requested UI
Projects
None yet
Development

No branches or pull requests

3 participants