Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Synchronization fails at 99% #75

Open
2 tasks done
VlaK0r opened this issue Nov 26, 2023 · 21 comments
Open
2 tasks done

[Bug]: Synchronization fails at 99% #75

VlaK0r opened this issue Nov 26, 2023 · 21 comments
Assignees
Labels
bug Something isn't working

Comments

@VlaK0r
Copy link

VlaK0r commented Nov 26, 2023

Bug description

It throws an error when trying to synchronize.

Local exception has occurred: Remote disconnected unexpectedly.
Local exception has occurred: Synchronization requested to close while connected.

1 time out of 100 synchronization is obtained.

Expected outcome

Successful synchronization

Steps to reproduce

I synchronize applications with PCs Debian 12 and Samsung 52 android 13
Synchronization fails in all directions.

Error log

Hosting... done. 
Listening... done.
Sending service info... done.
Receiving hello... done.
Client supports 2.0.0+ synchronization. Starting 2.0.0+ synchronization server... done.
Sending 2.0.0+ synchronization server address... 
Local exception has occurred: Remote disconnected unexpectedly.
Local exception has occurred: Synchronization requested to close while connected.

App version

v1.6.0 - Markdown Notes

Submission checklist

  • I have specified the problem in the issue title
  • I have provided a verbose description of the problem
@VlaK0r VlaK0r added the bug Something isn't working label Nov 26, 2023
@GleammerRay
Copy link
Collaborator

Hello @VlaK0r ! Thank you for reporting your error. Unfortunately, this server log doesn't tell much other than that the client has experienced an error. I would need the client log to determine the problem. Thank you!

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Hello @VlaK0r ! Thank you for reporting your error. Unfortunately, this server log doesn't tell much other than that the client has experienced an error. I would need the client log to determine the problem. Thank you!

PS or smartphone client log?

@GleammerRay
Copy link
Collaborator

Client as in the one that connects to the host (the one that scans the QR code).

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Client as in the one that connects to the host (the one that scans the QR code).

So it's a smartphone.
How do I copy logs from the app on my smartphone?

@GleammerRay
Copy link
Collaborator

It should show the same bar at the bottom as your computer. Press the Details button once you see it.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Connecting...
Local exception has occurred: Failed to connect.
SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = 192.168.1.101, port = 37316
#0 _NativeSocket.startConnect (dart:io-patch/socket_patch.dart:706)
#1 _NativeSocket.connect (dart:io-patch/socket_patch.dart:969)
#2 _RawSocket.connect (dart:io-patch/socket_patch.dart:1852)
#3 RawSocket.connect (dart:io-patch/socket_patch.dart:21)
#4 Socket._connect (dart:io-patch/socket_patch.dart:2077)
#5 Socket.connect (dart:io/socket.dart:750)
#6 Synchronization.connect (package:passy/passy_data/synchronization.dart:1309)

@GleammerRay
Copy link
Collaborator

GleammerRay commented Nov 26, 2023

Hmm. It seems as though your computer does not allow your phone to connect to the Passy synchronization server for some reason. Are you sure you don't have any firewall rules in place that might be blocking the server from exposing itself? This might also be caused by any VPNs or proxies in use.

Edit 1: also, try hosting from your phone and connect from your computer to see if that works.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Edit 1: also, try hosting from your phone and connect from your computer to see if that works.

The same thing happens.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Hmm. It seems as though your computer does not allow your phone to connect to the Passy synchronization server for some reason. Are you sure you don't have any firewall rules in place that might be blocking the server from exposing itself? This might also be caused by any VPNs or proxies in use.

VPN definitely not
I did not install a firewall, unless there is a built-in debian.
Sometimes the synchronization goes through! That's weird. If something was blocking, it would block 100%.

@GleammerRay
Copy link
Collaborator

I am on Ubuntu 22.04 and I do not have the same problem. I must note that I remember something similar happening to me before, but since I'm using the dev branch for a while kow I can't quite tell if it's still a problem.

It might be resolved in the next release. For now it would be fair to assume that it's a Dart bug (which I don't exactly have control over).

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

It might be resolved in the next release. For now it would be fair to assume that it's a Dart bug (which I don't exactly have control over).

Please tell me when the next release is expected?

@GleammerRay
Copy link
Collaborator

The next release will most probably be out today or tomorrow, but it will take some time for the F-Droid build to release (1-2 weeks).

I must note that the new synchronization optimizations I've implemented will only be available for accounts with Argon2 key derivation enabled (will be accessible through account security settings). Due to incompatibility of synchronization between legacy and Argon2 accounts it is important that you have Argon2 key derivation enabled on all of your devices for them to synchronize correctly.

I am unsure as to whether the optimizations I have included will fix this problem for you, but I have been using this new process for a while now and haven't been experiencing any problems with it.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

Forgive me.
I have misled you.
Synchronization does not work only through the camera.
Now I have rebooted my smartphone, and if I manually enter the host, then everything works.
Only all the time it finds some changes, deletes and adds something.

@GleammerRay
Copy link
Collaborator

I am happy to hear that you have managed to resolve your problem!

As per the synchronization history stability issue, it is acknowledged in #69 . You shouldn't worry about it unless you're using more than 2 devices. It will be resolved as soon as you install the next release on both of your devices.

@GleammerRay
Copy link
Collaborator

I must note that synchronization can not fail through camera if it doesn't fail through manual input, the QR code is encoding the same IP address as the one shown below it.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

I must note that synchronization can not fail through camera if it doesn't fail through manual input, the QR code is encoding the same IP address as the one shown below it.

I checked it again.
Using the camera does not sync.
And with manual input, everything is fine.

@GleammerRay GleammerRay reopened this Nov 26, 2023
@GleammerRay
Copy link
Collaborator

QR code can not be the cause since the value used in it is precisely identical to the one shown for manual input. This probably means that synchronization is still occasionally faulty on your end. I will leave this issue open for now.

@VlaK0r
Copy link
Author

VlaK0r commented Nov 26, 2023

QR code can not be the cause since the value used in it is precisely identical to the one shown for manual input. This probably means that synchronization is still occasionally faulty on your end. I will leave this issue open for now.

I agree.
Can I also ask a question off topic?
When are you planning to add support for the firefox plugin?

@GleammerRay
Copy link
Collaborator

The Firefox addon review process is very strict. I am having some issues during the compliance process due to inconsistent build hashes. I hope to resolve this by early 2024.

@GleammerRay
Copy link
Collaborator

GleammerRay commented Nov 28, 2023

@VlaK0r Next release is out and can be downloaded for PC at https://github.com/GlitterWare/Passy/releases/v1.7.0. For Android, I recommend to wait for the F-Droid release (1-2 weeks).

@GleammerRay
Copy link
Collaborator

GleammerRay commented Dec 17, 2023

@VlaK0r the Firefox extension is now available at https://addons.mozilla.org/en-US/addon/passy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants