Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error saving and display result #389

Open
dmvstar opened this issue Dec 26, 2017 · 7 comments
Open

Error saving and display result #389

dmvstar opened this issue Dec 26, 2017 · 7 comments

Comments

@dmvstar
Copy link

dmvstar commented Dec 26, 2017

System config in mmol/L.
Adding and saving result, for example - 11,8, after saving result on list is 118 !
screenshot_2017-12-26-09-29-12-066_org glucosio android daily
screenshot_2017-12-26-09-29-22-679_org glucosio android daily
screenshot_2017-12-26-09-29-32-579_org glucosio android daily

@AndyScherzinger
Copy link

@emartynov could this be related/fixed by your decimal support changes?
Imho this is a locale depending issue since US uses "," for the 1K delimiter while most european countries use "." so you end up with
(US) 1,000.00 == 1.000,00 (DE)
for example, thus parsing user inputs would have to respect locales. :/

@emartynov
Copy link
Contributor

As I saw this issue I've tested it. And it worked fine for me. So most probably mu decimal support changes will also fix this issue. However, I never was sharp in the remembering decimal separator. So, my proposal would be to make it locale-independent.

@AndyScherzinger
Copy link

So, my proposal would be to make it locale-independent.

As in always use a dot for decimals or separate it into 2 fields on the UI level?

@dmvstar
Copy link
Author

dmvstar commented Dec 28, 2017

When I change liocale to English - work fine,
but when I restore to my locale then - wrong.
screenshot_2017-12-28-14-40-07-571_com android settings
screenshot_2017-12-28-14-41-50-479_org glucosio android daily
screenshot_2017-12-28-14-43-27-715_org glucosio android daily

@emartynov
Copy link
Contributor

I propose no matter dot or coma used always treat it as the separator

@emartynov
Copy link
Contributor

@dmvstar Interesting notice - you have Polish locale but Ukraine region! (I'm from Ukraine)

@dmvstar
Copy link
Author

dmvstar commented Dec 28, 2017

@emartynov - yes I am from Ukraine but testing Polish translation and locale.
If I select Russian locale, I have same problem )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants