Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Remove forced authentication...!!! #312

Open
WolfgangSenff opened this issue Oct 5, 2022 · 0 comments
Open

[FEATURE REQUEST] - Remove forced authentication...!!! #312

WolfgangSenff opened this issue Oct 5, 2022 · 0 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@WolfgangSenff
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The plugin is mature enough and our license is strong enough that we cannot be held liable should a person choose not to use authentication. This was a feature before when it was newer, just to prevent anyone from attempting to abuse us, but now it's extra. And most people know they should use authentication. Hence, we can remove the requirement throughout the codebase!

Describe the solution you'd like
We'd need to find everywhere that we forcibly login and remove them. In addition to that, we need to ensure that we handle errors properly when a user requires auth but has not implemented it in their code. This could be a lot of effort, as it may involve looking through the entire codebase. I'm hopeful we have most of the places covered, but where possible, add more details about why the request failed if it's auth-related.

Describe alternatives you've considered
Just leaving it is the only alternative, but we don't need it and it impedes some (dangerous) developers.

Additional context
This will require a few more tests in our tester, found at github.com/GodotNuts. Feel free to add them, or open an issue there so we can.

@WolfgangSenff WolfgangSenff added enhancement New feature or request Hacktoberfest labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant