Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp.bin file not cleared #2

Open
suloku opened this issue Nov 26, 2021 · 0 comments
Open

tmp.bin file not cleared #2

suloku opened this issue Nov 26, 2021 · 0 comments

Comments

@suloku
Copy link

suloku commented Nov 26, 2021

The script doesn't check for tmp.bin file's existence before uploading a file, so if a file named tmp.bin already exists, fspd will append the upload contents to tmp.bin and move the file afterwards to correct filename.

I found this after my client crashed mid-upload.

Proposed solution:

  • Check for the presence of tmp.bin before a file is uploaded, delete it since it shouldn't be there before uploading a file.
  • Maybe change the name to fspd.tmp to avoid conflicting since tmp.bin is too generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant