Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

Run on non-PR's #34

Open
kontrollanten opened this issue Jun 8, 2018 · 4 comments · May be fixed by #35
Open

Run on non-PR's #34

kontrollanten opened this issue Jun 8, 2018 · 4 comments · May be fixed by #35

Comments

@kontrollanten
Copy link

kontrollanten commented Jun 8, 2018 •
edited
Loading

Thanks for a great package! In my case my site is not deployed through Travis, instead my deploy service (Netlify) triggers a web hook to run e2e and lighthouse after deploy.

Would it be possible to allow this to be ran on non-pull request events in Travis? Then it could fetch PR number, etc from the GH API; like https://api.github.com/repos/ebidel/lighthouse-ci/pulls
@ebidel
Copy link
Contributor

ebidel commented Jun 8, 2018 via email

@kontrollanten
Copy link
Author

I'm triggering my Travis build with the API after I've deployed my PR preview

@kontrollanten
Copy link
Author

I made a fork to do a poc; kontrollanten@b6ad518

Please let me know if you want me to do a PR

@ebidel
Copy link
Contributor

ebidel commented Jun 8, 2018

Ah neat. Yea, a PR would be great. Changes are pretty minimal and I like the idea of making this more configurable :)

@kontrollanten kontrollanten linked a pull request Jun 9, 2018 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for running on non-PR triggered Travis builds kontrollanten/lighthouse-ci
2 participants
@ebidel @kontrollanten