Added Support for Microsoft's OpenJDK package #5252
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -0,0 +1,45 @@ | |||
| # linux_packages/openjdk_msft.py | |||
There was a problem hiding this comment.
Styling nit: Can you add the usual copyright block (see another file, e,g, aerospike_client.py, for example. you just need to update the year) at the top?
After that, add a docstring such as
"""Module to install Microsoft's OpenJDK package."""
There was a problem hiding this comment.
I am going to pull this change in for now. Feel free to open another pull request to add the docstring and copyright block.
copybara-service
bot
merged commit 706ed21
into
GoogleCloudPlatform:master
Contribution for the following open issue #5232