-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of WarPluginConvention #998
Comments
Thanks for the note! |
There's no clear eta for the release at this point, but the main branch is already set to 8.0. It will be the next release after the upcoming 7.6. |
Thanks for the context @donat. Also linking the official docs here for future reference: https://docs.gradle.org/current/dsl/org.gradle.api.plugins.WarPluginConvention.html. |
For the record: this removal was postponed to 9.0, and the Conventions are now nagging since Gradle 8.2. I did a little bit of investigation: To make this plugin compatible, it's necessary to get access to the |
I ran into this again, while upgrading an old project. I captured the nagging stack traces on Gradle 8.2.1 for reference. The Project.getConvention() method has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.WarPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#war_convention_deprecation
Luckily there's a trivial workaround: avoid using the generic @donat what's the plan, is this more likely going ahead in 9.0? |
The type will be removed in Gradle 8.0.
https://github.com/GoogleCloudPlatform/app-gradle-plugin/blob/f50be8dcdde14ec6ef94947f1e21f5ea855be792/src/main/java/com/google/cloud/tools/gradle/appengine/AppEnginePlugin.java#L28
The text was updated successfully, but these errors were encountered: