Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate helm deployer guide to schema v2 #487

Closed
huyhg opened this issue Apr 6, 2020 · 2 comments · Fixed by #497
Closed

Migrate helm deployer guide to schema v2 #487

huyhg opened this issue Apr 6, 2020 · 2 comments · Fixed by #497

Comments

@huyhg
Copy link
Contributor

huyhg commented Apr 6, 2020

This file docs/building-deployer-helm.md

@pgoldtho
Copy link

pgoldtho commented Apr 28, 2020

Please update docs/verification-integration.md at the same time to describe required changes to the deployer Dockerfile (e.g. https://github.com/GoogleCloudPlatform/click-to-deploy/blob/master/k8s/wordpress/deployer/Dockerfile instead of FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild) and explain how to determine the correct value for MARKETPLACE_TOOLS_TAG.

It would be nice if the verification document continued the tutorial started in the deployer guide i.e. it developed a Wordpress test.

@gibbleyg gibbleyg linked a pull request May 11, 2020 that will close this issue
@gibbleyg
Copy link
Contributor

Hey @pgoldtho,

The documentation in docs/building-deployer-helm.md doesn't exactly follow the same workflow as the click-to-deploy repository, thus we would still be using the same Dockerfile, containing only FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild.

Thanks for the callout on the verification doc, it makes sense to continue the wordpress example. I have created a separate issue #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants