Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Errors for users when Metrics are submitted in too quick succession or out of order #69

Open
jsuereth opened this issue Jan 22, 2021 · 2 comments
Open

Better Errors for users when Metrics are submitted in too quick succession or out of order #69

jsuereth opened this issue Jan 22, 2021 · 2 comments
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request metrics Metrics Exporter related priority: p3

Comments

@jsuereth
Copy link
Collaborator

Cloud Monitoring can throttle Metric timeseries that are sent in too quick sucession, or out of order.

This client can take two approaches to the problem:

  1. Avoid sending the data through detection and issuing a clear error message for users.
  2. Handling the failure to write the TimeSeries gracefully and issuing a clear error message for users.

Current approach is to try #1, but we're lacking refinement in the error messages for users to diagnose and fix the issue.
@jsuereth jsuereth added the enhancement New feature or request label Jan 22, 2021
@jsuereth jsuereth mentioned this issue Jan 22, 2021
Merged
@jsuereth jsuereth added the metrics Metrics Exporter related label Jan 25, 2021
@aabmass aabmass added priority: p3 enhancement accepted An actionable enhancement for which PRs will be accepted and removed priority: p2 labels Nov 30, 2022
@aabmass
Copy link
Contributor

aabmass commented Nov 30, 2022

Not prioritizing this right now but would be happy to review a PR based on Josh's proposed solution.

@aabmass
Copy link
Contributor

aabmass commented Apr 10, 2023 •
edited
Loading

Looking through the backlog, still not a high priority in Java. It would be nice to fix this issue in the collector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request metrics Metrics Exporter related priority: p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsuereth @aabmass @dashpole