Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Availability and Port #35

Open
moxious opened this issue Mar 26, 2018 · 2 comments
Open

HTTP Availability and Port #35

moxious opened this issue Mar 26, 2018 · 2 comments
Assignees

Comments

@moxious
Copy link
Collaborator

moxious commented Mar 26, 2018

Just a comment on what I'm seeing but the default behavior of ubbagent-start is to disable HTTP access unless a port is provided. I would expect port 3456 to be used as the default (or whatever you choose).

Additionally, it's undocumented and unclear what this application should do at all if HTTP is disabled. Suggest defaulting to port 3456 and always enabling HTTP unless explicitly disabled by configuration (in the event that's useful)

@jvolkman
Copy link
Contributor

Thanks for the suggestion. It's possible to have the agent auto-report at predefined intervals (i.e., to report only usage time), at which point the HTTP interface isn't strictly necessary. Although even in this case, we still recommend monitoring its /status endpoint.

I'd rather not prescribe a default port. What about another option: require the port parameter, and allow it to optionally be set to "disabled" to explicitly disable the HTTP interface.

@jvolkman jvolkman self-assigned this Apr 18, 2018
@moxious
Copy link
Collaborator Author

moxious commented Apr 18, 2018

I think most of the time what the port is won't matter if this is in the sidecar, I can't imagine it conflicting with much else. It's not really something I'd even have much opinion about, which is why I was thinking it makes sense to have a default.

Admittedly this is preference; it's nice to have tools that do something sensible in the default without much configuration, but that allow control on the elements you care enough to change. I like to avoid making decisions that don't much matter to my development process, and delegate those to the original author, I have enough decisions to make. :)

All of that being said, it's kind of a minor point, hardly a dealbreaker as long as it's clear either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants