Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Champion model evaluation #71

Open
wambergo opened this issue Dec 20, 2023 · 0 comments
Open

Incorrect Champion model evaluation #71

wambergo opened this issue Dec 20, 2023 · 0 comments

Comments

@wambergo
Copy link

It looks like the evaluation of the Champion model is an evaluation of the Challenger model:
https://github.com/GoogleCloudPlatform/vertex-pipelines-end-to-end-samples/blob/a78d2f648bbbd303517d371cee0bc9b9985a5fa2/components/vertex-components/src/vertex_components/update_best_model.py#L62C15-L62C15

Suggested update: eval_champion = champion.get_model_evaluation()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wambergo