Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only ship .js and .d.ts files when distributing to npm #35

Open
DanielRosenwasser opened this issue Apr 25, 2017 · 0 comments
Open

Only ship .js and .d.ts files when distributing to npm #35

DanielRosenwasser opened this issue Apr 25, 2017 · 0 comments

Comments

@DanielRosenwasser
Copy link

Right now, users who are trying to consume this library with TypeScript using settings like noImplicitAny are having a negative user experience because the packaged .ts files are getting fully re-checked. See microsoft/TypeScript#15363 for an example of a problem caused by this.

Running TypeScript with --declaration to produce .d.ts files and adding your regular .ts files to an .npmignore file will prevent this issue.
@DanielRosenwasser DanielRosenwasser mentioned this issue Apr 25, 2017
Closed
sciolizer added a commit to sciolizer/node-k8s-client that referenced this issue Apr 25, 2017
@sciolizer
shipping .d.ts instead of .ts Goyoo#35
9bcfeed
@dkapanidis dkapanidis mentioned this issue Apr 29, 2017
Open
mmoonn2 added a commit that referenced this issue Apr 29, 2017
@mmoonn2
Merge pull request #37 from sciolizer/dts
090f23b 
shipping .d.ts instead of .ts #35
@kkimdev kkimdev mentioned this issue May 9, 2017
Closed
@JounQin JounQin mentioned this issue Nov 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielRosenwasser