Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency for coding style #3

Closed
peter279k opened this issue Aug 17, 2020 · 3 comments
Closed

Consistency for coding style #3

peter279k opened this issue Aug 17, 2020 · 3 comments

Comments

@peter279k
Copy link

Firstly, thanks for your demo PHP project about CSRF :).

I wonder know what kinds of coding style does this project follow?

And I think it will be good for upcoming commits/PRs to follow style easily 👍 .

@peter279k
Copy link
Author

@GramThanos, I think we can consider following PSR-2 or PSR-12 coding style.

What do you think about this :)?

@GramThanos
Copy link
Owner

I haven't used coding styles on PHP before.
So... I tried porting the library to PSR-12 (can be found on dev branch)... I don't like it :P

I also think this project is too small to define code styles, especially since there are no pull requests.
This is also why I don't think that a namespace is needed #4

@peter279k
Copy link
Author

Never mind. It's up to you to determine whether coding style is integrated or not :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants