Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DPI display scaling to make overlays render at the native resolution #1688

Open
Keavon opened this issue Mar 14, 2024 · 2 comments · May be fixed by #2073
Open

Fix DPI display scaling to make overlays render at the native resolution #1688

Keavon opened this issue Mar 14, 2024 · 2 comments · May be fixed by #2073
Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend

Comments

@Keavon
Copy link
Member

Keavon commented Mar 14, 2024

We use a <canvas> element for displaying our overlays on top of the artwork. But for users with a DPI display scaling ratio other than 100%, this won't be drawn correctly. Then the rounding in the overlay drawing code, which is designed to ensure that overlays are rendered crisply without antialiasing fuzziness, will also need to be updated to ensure that continues to work at a new pixel grid ratio/alignment.
@Keavon Keavon added Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend labels Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Mar 14, 2024
@CheeksTheGeek
Copy link

I want to work on this task, would you be able to give some starting point in the codebase if I'm possibly looking at the wrong place? Right now I'm thinking about making a change somewhere around https://github.com/GraphiteEditor/Graphite/blob/master/frontend/src/components/floating-menus/EyedropperPreview.svelte#L17
image

@0HyperCube
Copy link
Member

@CheeksTheGeek You'll want to look in editor/src/messages/portfolio/document/overlays/overlays_message_handler.rs.

@Keavon Keavon moved this from Short-Term to Medium-Term in Task Board Jun 9, 2024
@Zamoca42 Zamoca42 linked a pull request Oct 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend
Projects
Task Board
Status: Medium-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve overlay rendering for DPI scaling Zamoca42/Graphite
3 participants
@Keavon @CheeksTheGeek @0HyperCube