Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login model issue #366

Open
divyanshu-rawat opened this issue Mar 3, 2017 · 5 comments
Open

Login model issue #366

divyanshu-rawat opened this issue Mar 3, 2017 · 5 comments

Comments

@divyanshu-rawat
Copy link

There is no left & right padding wrt browser window.
Screen Size - md
md

Screen Size - sm
sm

Screen SIze - xs
xs

Can I work on this issue ?

@divyanshu-rawat
Copy link
Author

@atfornes please look at the issue .

@atfornes
Copy link
Contributor

atfornes commented Mar 4, 2017

@divyanshu-rawat, feel free to work in this issue if you like.

I will soon prioritize and mark important and easy issues in Teem so it is easier to find on what to work.

@divyanshu-rawat
Copy link
Author

divyanshu-rawat commented Mar 5, 2017

@atfornes I tried solving it

Snapshot after fixing in chrome dev tools when screen size is xs

issue_xs

Snapshot after fixing in chrome dev tools when screen size is sm

issue_sm

But the issue that I am facing right now is that I am not been able to figure out where the .model-dialog class is located in the source code.
As per snapshot, I changed the padding of .model-dialog class from 0 to 5% that's why the model is not touching left and right browser window.
But In order to make a permanent change, I need to find where .model-class is located in source code.

Why chrome dev tools are pointing to colors.sass?
colors.sass does not contain any .model-dialog class !

@krshubham
Copy link
Contributor

krshubham commented Mar 5, 2017

@divyanshu-rawat Here is the modal.scss at src/sass/modal.sass file which has the details of the modal dialog class. I added 5% to padding and it did the job!

screen shot 2017-03-05 at 6 31 34 pm

divyanshu-rawat added a commit to divyanshu-rawat/teem that referenced this issue Mar 5, 2017
@krshubham
Copy link
Contributor

@atfornes , what about this issue? Should I make the padding changes, or its not needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants