Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Problems with ImageFetchException #55

Open
ross85 opened this issue May 7, 2012 · 4 comments
Open

Problems with ImageFetchException #55

ross85 opened this issue May 7, 2012 · 4 comments

Comments

@ross85
Copy link

ross85 commented May 7, 2012

I have a pipeline that use Goose to download text form news articles. Sometimes can happen that a bad article stop the pipeline because Goose can't download images and raise exceptions for every image every 2 minutes, like in the following log example.

May 7, 2012 3:12:13 AM com.gravity.goose.utils.Logging$class info
INFO: com.gravity.goose.network.ImageFetchException: com.gravity.goose.network.ImageFetchException ==> Failed to fetch image file from imgSrc: http://rss.feedsportal.com/flickr/foto/2011_01/5350399008_96bfb1d665_s.jpg
May 7, 2012 3:14:13 AM com.gravity.goose.utils.Logging$class info
INFO: com.gravity.goose.network.ImageFetchException: com.gravity.goose.network.ImageFetchException ==> Failed to fetch image file from imgSrc: http://rss.feedsportal.com/flickr/foto/2011_09/6165889887_57c08896b9_s.jpg
May 7, 2012 3:16:13 AM com.gravity.goose.utils.Logging$class info
INFO: com.gravity.goose.network.ImageFetchException: com.gravity.goose.network.ImageFetchException ==> Failed to fetch image file from imgSrc: http://rss.feedsportal.com/flickr/foto/2010_10/4935053263_ef10f461c5_s.jpg

I wish to catch the exception and stop the process of that news, by I can't caught the exception... someone can help me?

@erraggy
Copy link
Contributor

erraggy commented May 8, 2012

Thank you for reporting this! I see the source of the problem is a catch without any rethrow here:
https://github.com/jiminoc/goose/blob/master/src/main/scala/com/gravity/goose/images/ImageUtils.scala#L183

It's a little late right now, but I have this queued up for a fix tomorrow and hope to update origin soon after.

@ross85
Copy link
Author

ross85 commented May 8, 2012

Thank you for the speed of the answer! It's the first time I write on github, i have to close the issue or you do it?

@erraggy
Copy link
Contributor

erraggy commented May 9, 2012

I'll close it when I commit the fix.

Thanks,
-- robbie

@erraggy
Copy link
Contributor

erraggy commented May 11, 2012

Well I obviously have not resolved this in the amount of time I had suggested, so I comment here once again to notify all that this WILL be fixed (along with other error swallowing bits of code) ASAP. I currently have a queue of tasks for my actual job that take priority. ;-}

Thank you for your patience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants