Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Cookies expiration #168

Open
JLDRM opened this issue Sep 13, 2019 · 0 comments
Open

Custom Cookies expiration #168

JLDRM opened this issue Sep 13, 2019 · 0 comments

Comments

@JLDRM
Copy link

JLDRM commented Sep 13, 2019

**I'm submitting a

[ ] bug report => Search github for a similar issue or PR before submitting
[X] support request => Suggested place for help and support is [stackoverflow]
[X] feature request => Please check if similar feature request does not exist 

Description

I don't know if this is a Support request or a Feature Request:

I'm under a business requirement that demands a custom cookie expiration. I searched for an option in LocalizeParser class to customize the COOKIE_EXPIRY variable declared in localize-router.parser.js. I'm using the language detection of the LocalizParser, the cookies option, with the private function _cacheWithCookies that uses the COOKIE_EXPIRY.

There is a way to customize that variable at the init of the LocalizeParser?

If not, I think the customization of the cookie expiry is a nice feature to include in the library.

Thanks for the job!

Environment:

Angular Version:

Angular CLI: 7.3.8
Node: 10.16.0
OS: win32 x64
Angular: 7.2.14
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.8
@angular-devkit/build-angular     0.13.8
@angular-devkit/build-optimizer   0.13.8
@angular-devkit/build-webpack     0.13.8
@angular-devkit/core              7.3.8
@angular-devkit/schematics        7.3.8
@angular/cli                      7.3.8
@ngtools/webpack                  7.3.8
@schematics/angular               7.3.8
@schematics/update                0.13.8
rxjs                              6.3.3
typescript                        3.2.4
webpack                           4.29.0

Localize Router Version:

^2.0.0-RC.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant