enable customizable hasher and symbol identifier. #203
clippy
21 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 21 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.82.0-nightly (a7399ba69 2024-08-31)
- cargo 1.82.0-nightly (8f40fc59f 2024-08-21)
- clippy 0.1.82 (a7399ba 2024-08-31)
Annotations
Check warning on line 31 in core/src/lib.rs
github-actions / clippy
name `BTCUSDT` contains a capitalized acronym
warning: name `BTCUSDT` contains a capitalized acronym
--> core/src/lib.rs:31:9
|
31 | BTCUSDT = 1,
| ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Btcusdt`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
Check warning on line 14 in core/src/util/fx_hasher.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> core/src/util/fx_hasher.rs:9:1
|
9 | / /// A speedy hash algorithm for use within rustc. The hashmap in liballoc
10 | | /// by default uses SipHash which isn't quite as speedy as we want. In the
11 | | /// compiler we're not really worried about DOS attempts, so we use a fast
12 | | /// non-cryptographic hash.
13 | | ///
14 | | /// This is the same as the algorithm used by Firefox -- which is a homespun
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 26 in core/src/util/async_runtime/waker.rs
github-actions / clippy
call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it
warning: call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it
--> core/src/util/async_runtime/waker.rs:26:9
|
26 | mem::forget(arc.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
note: argument has type `std::mem::ManuallyDrop<std::sync::Arc<U>>`
--> core/src/util/async_runtime/waker.rs:26:21
|
26 | mem::forget(arc.clone());
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_non_drop
= note: `#[warn(clippy::forget_non_drop)]` on by default
Check warning on line 21 in core/src/lib.rs
github-actions / clippy
struct `RemContext` is never constructed
warning: struct `RemContext` is never constructed
--> core/src/lib.rs:21:12
|
21 | struct RemContext;
| ^^^^^^^^^^
|
= note: `RemContext` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check warning on line 117 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:117:28
|
117 | tail: CachePadded::new(AtomicUsize::new(0)),
| ^^^
Check warning on line 116 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:116:28
|
116 | head: CachePadded::new(AtomicUsize::new(0)),
| ^^^
Check warning on line 117 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:117:15
|
117 | tail: CachePadded::new(AtomicUsize::new(0)),
| ^^^^^^^^^^^
Check warning on line 116 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:116:15
|
116 | head: CachePadded::new(AtomicUsize::new(0)),
| ^^^^^^^^^^^
Check warning on line 26 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:26:11
|
26 | tail: CachePadded<AtomicUsize>,
| ^^^^^^^^^^^
Check warning on line 21 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:21:11
|
21 | head: CachePadded<AtomicUsize>,
| ^^^^^^^^^^^
Check warning on line 14 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:14:19
|
14 | use cache_padded::CachePadded;
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Check warning on line 74 in examples/./src/log.rs
github-actions / clippy
unneeded unit return type
warning: unneeded unit return type
--> examples/./src/log.rs:74:33
|
74 | F: FnMut(Box<dyn Value>) -> () + Send + 'static,
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
Check warning on line 14 in core/src/util/fx_hasher.rs
github-actions / clippy
first doc comment paragraph is too long
warning: first doc comment paragraph is too long
--> core/src/util/fx_hasher.rs:9:1
|
9 | / /// A speedy hash algorithm for use within rustc. The hashmap in liballoc
10 | | /// by default uses SipHash which isn't quite as speedy as we want. In the
11 | | /// compiler we're not really worried about DOS attempts, so we use a fast
12 | | /// non-cryptographic hash.
13 | | ///
14 | | /// This is the same as the algorithm used by Firefox -- which is a homespun
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
Check warning on line 26 in core/src/util/async_runtime/waker.rs
github-actions / clippy
call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it
warning: call to `std::mem::forget` with a value that does not implement `Drop`. Forgetting such a type is the same as dropping it
--> core/src/util/async_runtime/waker.rs:26:9
|
26 | mem::forget(arc.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
note: argument has type `std::mem::ManuallyDrop<std::sync::Arc<U>>`
--> core/src/util/async_runtime/waker.rs:26:21
|
26 | mem::forget(arc.clone());
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_non_drop
= note: `#[warn(clippy::forget_non_drop)]` on by default
Check warning on line 117 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:117:28
|
117 | tail: CachePadded::new(AtomicUsize::new(0)),
| ^^^
Check warning on line 116 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated associated function `cache_padded::CachePadded::<T>::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:116:28
|
116 | head: CachePadded::new(AtomicUsize::new(0)),
| ^^^
Check warning on line 117 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:117:15
|
117 | tail: CachePadded::new(AtomicUsize::new(0)),
| ^^^^^^^^^^^
Check warning on line 116 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:116:15
|
116 | head: CachePadded::new(AtomicUsize::new(0)),
| ^^^^^^^^^^^
Check warning on line 26 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:26:11
|
26 | tail: CachePadded<AtomicUsize>,
| ^^^^^^^^^^^
Check warning on line 21 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:21:11
|
21 | head: CachePadded<AtomicUsize>,
| ^^^^^^^^^^^
Check warning on line 14 in core/src/util/spsc.rs
github-actions / clippy
use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html).
--> core/src/util/spsc.rs:14:19
|
14 | use cache_padded::CachePadded;
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default