Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager approves an Activity Report #137

Closed
2 tasks done
pamlo412 opened this issue Nov 6, 2020 · 2 comments · Fixed by #281
Closed
2 tasks done

Manager approves an Activity Report #137

pamlo412 opened this issue Nov 6, 2020 · 2 comments · Fixed by #281
Assignees
Labels
5 Story Points AR Submit & Approve Issues concerning the Review and Submit section of ARs enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue

Comments

@pamlo412
Copy link
Contributor

pamlo412 commented Nov 6, 2020

User story:
As a manager who approves Activity Reports and sees some needing approval on my Home page, I want to be able to open the submitted report, read it, and approve it, so that I can do my part to help the TTA Specialist complete their work.

Acceptance Criteria:

  • in a submitted report assigned to a manager for review and approval, that manager can select an option to approve the report
  • an approved report's status changes to "Approved"

Design link: https://preview.uxpin.com/ad995fd722bd26c0f9a1c8a115f1b41833637308#/pages/134880478/simulate/sitemap

Exclusions:

@pamlo412 pamlo412 added enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Nov 6, 2020
@pamlo412 pamlo412 added AR Submit & Approve Issues concerning the Review and Submit section of ARs Needs Design Flag to alert designer labels Nov 24, 2020
@PatricePascual-ACF
Copy link
Contributor

@pamlo412 - Just to flesh this out a bit more for design @arickalewis1:
"- [ ] if there is more than one approving managers, the report remains in a "Pending Approval" status until all assigned managers have approved it"

When a report has two approvers, there's a distincion between the "My Activity Report" view/status and the "Region (X) Activity Reports" status.
Manager 1, who has approved the report, will not expect to see that report in their "My Activity..." list because their work is done.
Manager 2, who still needs to approve the report, will need it to show up as "Needs Action" on their "My Activity..." list.
The report status under "Region (X)..." can still show "Pending Approval."

@pamlo412
Copy link
Contributor Author

@PatricePascual-ACF - your comment above affects the display on the Home page, so I'm adding your notes to #181

@pamlo412 pamlo412 added 5 Story Points and removed Needs Design Flag to alert designer labels Dec 16, 2020
@marriej marriej changed the title Manager approves an Activity Report (no requested revisions) Manager approves an Activity Report Dec 22, 2020
@jasalisbury jasalisbury self-assigned this Feb 1, 2021
rahearn pushed a commit that referenced this issue Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Points AR Submit & Approve Issues concerning the Review and Submit section of ARs enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Projects
None yet
3 participants