Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing multiple publications test breaks with sqlite and postgresql #7

Open
nwoetzel opened this issue Nov 3, 2016 · 1 comment
Open

Importing multiple publications test breaks with sqlite and postgresql #7

nwoetzel opened this issue Nov 3, 2016 · 1 comment
Assignees
@nwoetzel
Labels
bug

Comments

@nwoetzel
Copy link
Member

nwoetzel commented Nov 3, 2016

postgresql: https://travis-ci.org/seek4science/seek/jobs/172687496
sqlite3: https://travis-ci.org/seek4science/seek/jobs/172687540

test_should_import_multiple_from_bibtex_file(PublicationsControllerTest) [/home/travis/build/seek4science/seek/test/functional/publications_controller_test.rb:177]:
<nil> expected to not be nil.```
@nwoetzel nwoetzel added the bug label Nov 3, 2016
@nwoetzel nwoetzel self-assigned this Nov 3, 2016
nwoetzel pushed a commit that referenced this issue Nov 4, 2016
fix for #7
0fe4ae4 
it seems that the encoding of the strings coming from a bibtex import is not quite correct - and sqlite will store them as binary - so that querying them does not work on those
stuzart added a commit to seek4science/seek that referenced this issue Nov 7, 2016
@stuzart
Merge pull request #40 from HITS-SDBV/ransack
7f353ac 
fix for HITS-SDBV#7
@nwoetzel
Copy link
Member Author

nwoetzel commented Nov 8, 2016

The patch will be rewritten following @fbacall's suggestion:
bibtex_file = params[:publication][:bibtex_file].set_encoding('utf-8')
Since the bibtex file comes through the form, the encoding might not be quite correct, which results in extracted texts to be not encoded as 'utf-8'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwoetzel nwoetzel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nwoetzel